Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remote_wal): introduce kafka remote wal #3001

Merged
merged 20 commits into from
Dec 26, 2023
Merged

feat(remote_wal): introduce kafka remote wal #3001

merged 20 commits into from
Dec 26, 2023

Conversation

niebayes
Copy link
Contributor

@niebayes niebayes commented Dec 25, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Publish a preview version of remote wal based on Apache Kafka.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@niebayes niebayes requested review from WenyXu, fengjiachun, killme2008 and MichaelScofield and removed request for WenyXu December 25, 2023 13:43
@niebayes niebayes added the docs-not-required This change does not impact docs. label Dec 25, 2023
@waynexia waynexia mentioned this pull request Dec 25, 2023
Closed
8 tasks
@github-actions github-actions bot removed the docs-not-required This change does not impact docs. label Dec 26, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2023 •
edited
Loading

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (bf635a6) 85.74% compared to head (4df0d4f) 85.63%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3001      +/-   ##
===========================================
- Coverage    85.74%   85.63%   -0.11%     
===========================================
  Files          784      784              
  Lines       126802   126824      +22     
===========================================
- Hits        108721   108603     -118     
- Misses       18081    18221     +140

@waynexia waynexia enabled auto-merge December 26, 2023 09:51
@waynexia waynexia disabled auto-merge December 26, 2023 09:51
@killme2008 killme2008 enabled auto-merge December 26, 2023 09:55
@killme2008 killme2008 added this pull request to the merge queue Dec 26, 2023
@waynexia waynexia removed this pull request from the merge queue due to a manual request Dec 26, 2023
@niebayes niebayes requested a review from killme2008 December 26, 2023 11:31
@niebayes niebayes changed the title feat(remote_wal): integrate remote wal to standalone feat(remote_wal): introduce kafka remote wal Dec 26, 2023
@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 26, 2023
Merged via the queue into develop with commit d061bf3 Dec 26, 2023
24 checks passed
@MichaelScofield MichaelScofield deleted the feat/integrate_remote_wal_standalone branch December 26, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@WenyXu WenyXu Awaiting requested review from WenyXu

@killme2008 killme2008 Awaiting requested review from killme2008

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niebayes @killme2008 @MichaelScofield @fengjiachun